aboutsummaryrefslogtreecommitdiffstats
path: root/src/panfrost/midgard/midgard_emit.c
diff options
context:
space:
mode:
authorAlyssa Rosenzweig <[email protected]>2019-08-30 17:29:17 -0700
committerTomeu Vizoso <[email protected]>2019-09-03 13:54:21 +0200
commit1a4153b24cce3f25db6bbc3dc5dc4efcfa146ab7 (patch)
tree64dc831dac09e47767e4aae77ac6fe392afa5ca4 /src/panfrost/midgard/midgard_emit.c
parent032e21b33e9765d645e624c8fb75d66c85d16e83 (diff)
pan/midgard: Fix cppcheck issues
Miscellaneous minor issues flagged by cppcheck. Signed-off-by: Alyssa Rosenzweig <[email protected]> Reviewed-by: Tomeu Vizoso <[email protected]>
Diffstat (limited to 'src/panfrost/midgard/midgard_emit.c')
-rw-r--r--src/panfrost/midgard/midgard_emit.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/panfrost/midgard/midgard_emit.c b/src/panfrost/midgard/midgard_emit.c
index 0d904f7166e..4f6ac05ab65 100644
--- a/src/panfrost/midgard/midgard_emit.c
+++ b/src/panfrost/midgard/midgard_emit.c
@@ -50,7 +50,6 @@ vector_to_scalar_source(unsigned u, bool is_int, bool is_full,
/* TODO: Integers */
unsigned component = (v.swizzle >> (2*masked_component)) & 3;
- bool upper = false; /* TODO */
midgard_scalar_alu_src s = { 0 };
@@ -69,8 +68,10 @@ vector_to_scalar_source(unsigned u, bool is_int, bool is_full,
if (s.full)
s.component = component << 1;
- else
+ else {
+ bool upper = false; /* TODO */
s.component = component + (upper << 2);
+ }
if (is_int) {
/* TODO */