diff options
| author | Nicolai Hähnle <[email protected]> | 2017-10-22 17:38:33 +0200 |
|---|---|---|
| committer | Nicolai Hähnle <[email protected]> | 2017-11-09 11:50:54 +0100 |
| commit | 0dcf30e55091a0c78fc84d98f5ea36286f3f1961 (patch) | |
| tree | b206ab6e846d2741653c0637ba29d2be9d57da6d /src/mesa | |
| parent | 0f54ee6072d067027c389d61abc7aea8956b2c1e (diff) | |
gallium: clarify the constraints on sampler_view_destroy
r600 expects the context that created the sampler view to still be alive
(there is a per-context list of sampler views).
svga currently bails when the context of destruction is not the same as
creation.
The GL state tracker, which is the only one that runs into the
multi-context subtleties (due to share groups), already guarantees that
sampler views are destroyed before their context of creation is destroyed.
Most drivers are context-agnostic, so the warning message in
pipe_sampler_view_release doesn't really make sense.
Reviewed-by: Marek Olšák <[email protected]>
Diffstat (limited to 'src/mesa')
| -rw-r--r-- | src/mesa/state_tracker/st_sampler_view.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mesa/state_tracker/st_sampler_view.c b/src/mesa/state_tracker/st_sampler_view.c index 0d7b63af75a..892725671d2 100644 --- a/src/mesa/state_tracker/st_sampler_view.c +++ b/src/mesa/state_tracker/st_sampler_view.c @@ -116,7 +116,6 @@ st_texture_release_all_sampler_views(struct st_context *st, { GLuint i; - /* XXX This should use sampler_views[i]->pipe, not st->pipe */ for (i = 0; i < stObj->num_sampler_views; ++i) pipe_sampler_view_release(st->pipe, &stObj->sampler_views[i].view); } |