summaryrefslogtreecommitdiffstats
path: root/src/mesa
diff options
context:
space:
mode:
authorEric Anholt <[email protected]>2014-05-21 14:31:31 -0700
committerKenneth Graunke <[email protected]>2014-07-02 12:45:59 -0700
commit6ded75ed08aed8a88b638c664efbfe14e0476f37 (patch)
tree645817b41a4cf5a299cc0167b31f5887c272760e /src/mesa
parente874274d0847733b2ae6c2efb911145d2da6e6b6 (diff)
i965/gen6: Add a spec citation about push constant packet requirements.
Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/mesa')
-rw-r--r--src/mesa/drivers/dri/i965/gen6_wm_state.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/src/mesa/drivers/dri/i965/gen6_wm_state.c b/src/mesa/drivers/dri/i965/gen6_wm_state.c
index db0e3aaaef7..047e036f5b6 100644
--- a/src/mesa/drivers/dri/i965/gen6_wm_state.c
+++ b/src/mesa/drivers/dri/i965/gen6_wm_state.c
@@ -76,7 +76,14 @@ upload_wm_state(struct brw_context *brw)
/* _NEW_BUFFERS */
bool multisampled_fbo = ctx->DrawBuffer->Visual.samples > 1;
- /* CACHE_NEW_WM_PROG */
+ /* CACHE_NEW_WM_PROG
+ *
+ * We can't fold this into gen6_upload_wm_push_constants(), because
+ * according to the SNB PRM, vol 2 part 1 section 7.2.2
+ * (3DSTATE_CONSTANT_PS [DevSNB]):
+ *
+ * "[DevSNB]: This packet must be followed by WM_STATE."
+ */
if (brw->wm.prog_data->base.nr_params == 0) {
/* Disable the push constant buffers. */
BEGIN_BATCH(5);