diff options
| author | Anuj Phogat <[email protected]> | 2014-06-06 14:53:12 -0700 |
|---|---|---|
| committer | Anuj Phogat <[email protected]> | 2014-08-04 17:11:34 -0700 |
| commit | 2d362a6aee0a1acab08590f2ba0ce50743546209 (patch) | |
| tree | 6f7a38a0ba5ff3dab7c2174eca76400114781da8 /src/mesa | |
| parent | 845b5ec89fb5543a3d38a31e1e8bc5f84449ea6c (diff) | |
mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3
Fixes few failures in gles3 Khronos CTS test: packed_pixels
Cc: "10.2" <[email protected]>
Signed-off-by: Anuj Phogat <[email protected]>
Reviewed-by: Jason Ekstrand <[email protected]>
Diffstat (limited to 'src/mesa')
| -rw-r--r-- | src/mesa/main/teximage.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 21ba4b624be..48a9128ef16 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -2711,6 +2711,17 @@ copytexture_error_check( struct gl_context *ctx, GLuint dimensions, "glCopyTexImage%dD(srgb usage mismatch)", dimensions); return GL_TRUE; } + + /* Page 139, Table 3.15 of OpenGL ES 3.0 spec does not define ReadPixels + * types for SNORM formats. Also, conversion to SNORM formats is not + * allowed by Table 3.2 on Page 110. + */ + if(_mesa_is_enum_format_snorm(internalFormat)) { + _mesa_error(ctx, GL_INVALID_OPERATION, + "glCopyTexImage%dD(internalFormat=%s)", dimensions, + _mesa_lookup_enum_by_nr(internalFormat)); + return GL_TRUE; + } } if (!_mesa_source_buffer_exists(ctx, baseFormat)) { |