summaryrefslogtreecommitdiffstats
path: root/src/mesa/tnl_dd
diff options
context:
space:
mode:
authorTimothy Arceri <[email protected]>2017-01-06 10:26:24 +1100
committerTimothy Arceri <[email protected]>2017-01-07 21:46:36 +1100
commit1edc53a66b33e4d17688a3d03b1bdffed2aec414 (patch)
treed5717e69bd15c687ee589ddb0c82c180cff1d61f /src/mesa/tnl_dd
parent45912fb908f7a1d2efbce0f1dbe81e5bc975fbe1 (diff)
glsl: fix opt_minmax redundancy checks against baserange
Marking operations as redundant if they are equal to the base range is fine when the tree structure is something like this: max / \ max b / \ 3 max / \ 3 a But the opt falls apart with a tree like this: max / \ max max / \ / \ 3 a b 3 The problem is that both branches are treated the same: descending in the left branch will prune the constant, and then descending the right branch will prune the constant there as well, because limits[0] wasn't updated to take the change on the left branch into account, and so we still get [3,\infty) as baserange. In order to fix the bug we just disable the marking of redundant expressions when they match the baserange. NIR algebraic opt will clean up the first tree for anyway, hopefully other backends are smart enough to do this also. Cc: "13.0" <[email protected]> Reviewed-by: Nicolai Hähnle <[email protected]>
Diffstat (limited to 'src/mesa/tnl_dd')
0 files changed, 0 insertions, 0 deletions