diff options
author | Michel Dänzer <[email protected]> | 2018-01-03 12:21:56 +0100 |
---|---|---|
committer | Michel Dänzer <[email protected]> | 2018-01-17 11:40:22 +0100 |
commit | 7b0e8264dd21ae05521d08d41fecd84139401fef (patch) | |
tree | 7a622a21947351bcc9ef1bd82855121cc94f0197 /src/mesa/state_tracker | |
parent | 0b8991c0b609831cdcb255cc5e9c516657dc8703 (diff) |
loader/dri3: Try to make sure we only process our own NotifyMSC events
We were using a sequence counter value to wait for a specific NotifyMSC
event. However, we can receive events from other clients as well, which
may already be using higher sequence numbers than us. In that case, we
could stop processing after an event from another client, which could
have been received significantly earlier. This would have multiple
undesirable effects:
* The computed MSC and UST values would be lower than they should be
* We could leave a growing number of NotifyMSC events from ourselves and
other clients in XCB's special event queue
I ran into this with Firefox and Thunderbird, whose VSync threads both
seem to use the same window. The result was sluggish screen updates and
growing memory consumption in one of them.
Fix this by checking the XCB sequence number and MSC value of NotifyMSC
events, instead of using our own sequence number.
v2:
* Use the Present event ID for the sequence parameter of the
PresentNotifyMSC request, as another safeguard against processing
events from other clients
* Rebase on drawable mutex changes
Reviewed-by: Nicolai Hähnle <[email protected]> # v1
Diffstat (limited to 'src/mesa/state_tracker')
0 files changed, 0 insertions, 0 deletions