diff options
author | Kenneth Graunke <[email protected]> | 2015-07-04 19:15:16 -0700 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2015-07-16 20:26:43 -0700 |
commit | 4b17f0d9f58637300b0748d1fb702a7e4d51979f (patch) | |
tree | fbbe1ae7c637e94a7415b7a89c3b6de1f1025ebf /src/mesa/program/program_parser.h | |
parent | 3a31876600cb5c4d90c998ecb5635c602eeb2bd1 (diff) |
program: Allow redundant OPTION ARB_fog_* directives.
A fragment program from "Pixel Piracy" contains redundant OPTION
directives:
!!ARBfp1.0
OPTION ARB_precision_hint_fastest;
OPTION ARB_fog_exp2;
OPTION ARB_precision_hint_fastest;
OPTION ARB_fog_exp2;
...
We already allow redundant ARB_precision_hint_fastest directives, but
disallow the redundant (yet consistent) ARB_fog_exp2 directives, failing
to compile the program.
The specification seems to contradict itself - the main text says that
only one fog application option may be specified, but then backpedals,
indicating the intent is to disallow /contradictory/ flags. One of the
issues suggests that specifying contradictory ones is stupid, but
allowed, and only the last one should take effect.
Accepting multiple redundant (but consistent) directives seems harmless,
and like a reasonable interpretation of the specification. It also
fixes a fragment program found in the wild.
Cc: [email protected]
Signed-off-by: Kenneth Graunke <[email protected]>
Reviewed-by: Ian Romanick <[email protected]>
Diffstat (limited to 'src/mesa/program/program_parser.h')
0 files changed, 0 insertions, 0 deletions