diff options
author | Iago Toral Quiroga <[email protected]> | 2019-01-21 12:11:44 +0100 |
---|---|---|
committer | Juan A. Suarez Romero <[email protected]> | 2019-04-18 11:05:18 +0200 |
commit | 0986199b31ab2a6086131887e474bc8f79fbc28d (patch) | |
tree | 1a70ea5493efd1d21c1e33f8240e5af857284c09 /src/mesa/main/sse_minmax.c | |
parent | aaae24179ff1007776d2f3a5a813f2c52dc83eba (diff) |
intel/compiler: workaround for SIMD8 half-float MAD in gen8
Empirical testing shows that gen8 has a bug where MAD instructions with
a half-float source starting at a non-zero offset fail to execute
properly.
This scenario usually happened in SIMD8 executions, where we used to
pack vector components Y and W in the second half of SIMD registers
(therefore, with a 16B offset). It looks like we are not currently doing
this any more but this would handle the situation properly if we ever
happen to produce code like this again.
v2 (Jason):
- Move this workaround to the lower_regioning pass as an additional case
to has_invalid_src_region()
- Do not apply the workaround if the stride of the source operand is 0,
testing suggests the problem doesn't exist in that case.
v3 (Jason):
- We want offset % REG_SIZE > 0, not just offset > 0
- Use a helper to compute the offset
Reviewed-by: Topi Pohjolainen <[email protected]> (v1)
Diffstat (limited to 'src/mesa/main/sse_minmax.c')
0 files changed, 0 insertions, 0 deletions