diff options
| author | Eduardo Lima Mitev <[email protected]> | 2015-07-29 16:01:28 +0200 |
|---|---|---|
| committer | Eduardo Lima Mitev <[email protected]> | 2015-08-05 08:20:16 +0200 |
| commit | 4b07e9a033ddb6733eba206b5bd47a2373756f7d (patch) | |
| tree | 2a18bf3cc9d752442feee83c2cbc2c93b1b851b6 /src/mesa/main/pipelineobj.h | |
| parent | 5d64cae8427b090c42d6d38da7fb474b3ddd4eb0 (diff) | |
mesa: Fix error returned by glCopyTexImage2D() upon an invalid internal format
Page 161 of the OpenGL-ES 3.1 (PDF) spec, and page 207 of the OpenGL 4.5 (PDF),
both on section '8.6. ALTERNATE TEXTURE IMAGE SPECIFICATION COMMANDS', states:
"An INVALID_ENUM error is generated if an invalid value is specified for
internalformat".
It is currently returning INVALID_OPERATION error because
_mesa_get_read_renderbuffer_for_format() is called before the internalformat
argument has been validated. To fix this, we move this call down the validation
process, after _mesa_base_tex_format() has been called. _mesa_base_tex_format()
effectively serves as a validator for the internal format.
Fixes 1 dEQP test:
* dEQP-GLES3.functional.negative_api.texture.copyteximage2d_invalid_format
Fixes 1 piglit test:
* spec@oes_compressed_etc1_rgb8_texture@basic
Reviewed-by: Ian Romanick <[email protected]>
Cc: 10.6 <[email protected]>
Diffstat (limited to 'src/mesa/main/pipelineobj.h')
0 files changed, 0 insertions, 0 deletions