diff options
author | Steinar H. Gunderson <[email protected]> | 2016-02-02 01:16:51 +0100 |
---|---|---|
committer | Marek Olšák <[email protected]> | 2016-02-05 17:18:17 +0100 |
commit | feb53912f8d8c29594a9fdff914d78bb36d6d56b (patch) | |
tree | 4ca9c61e7609a67a65789ad85202376b768f2df0 /src/mesa/main/config.h | |
parent | 156e81f305b19f62b4d6ea98bf44a951e89dc947 (diff) |
mesa: Fix locking of GLsync objects.
GLsync objects had a race condition when used from multiple threads
(which is the main point of the extension, really); it could be
validated as a sync object at the beginning of the function, and then
deleted by another thread before use, causing crashes. Fix this by
changing all casts from GLsync to struct gl_sync_object to a new
function _mesa_get_and_ref_sync() that validates and increases
the refcount.
In a similar vein, validation itself uses _mesa_set_search(), which
requires synchronization -- it was called without a mutex held, causing
spurious error returns and other issues. Since _mesa_get_and_ref_sync()
now takes the shared context mutex, this problem is also resolved.
Fixes bug #92757, found while developing Nageru, my live video mixer
(due for release at FOSDEM 2016).
v2: Marek: silence warnings, fix declaration after code
Signed-off-by: Steinar H. Gunderson <[email protected]>
Cc: "11.0 11.1" <[email protected]>
Signed-off-by: Marek Olšák <[email protected]>
Diffstat (limited to 'src/mesa/main/config.h')
0 files changed, 0 insertions, 0 deletions