summaryrefslogtreecommitdiffstats
path: root/src/mesa/drivers
diff options
context:
space:
mode:
authorAlex Deucher <[email protected]>2009-09-23 19:42:07 -0400
committerAlex Deucher <[email protected]>2009-09-23 19:42:07 -0400
commit1bf0651d9b58a5c150fcf37016ae1bda425bb05a (patch)
tree08d516a0fc742d213f054e9fec0b256778b9f0ac /src/mesa/drivers
parent20e77382935b24e9e2be89cd2b686fa2f1f67635 (diff)
r600: fix up ordering of functions in draw prims path
Shaders and IB need to be updated and allocated before calling validatebuffers.
Diffstat (limited to 'src/mesa/drivers')
-rw-r--r--src/mesa/drivers/dri/r600/r700_render.c31
1 files changed, 15 insertions, 16 deletions
diff --git a/src/mesa/drivers/dri/r600/r700_render.c b/src/mesa/drivers/dri/r600/r700_render.c
index bdf0bfc0e43..bbe364bc6aa 100644
--- a/src/mesa/drivers/dri/r600/r700_render.c
+++ b/src/mesa/drivers/dri/r600/r700_render.c
@@ -1019,7 +1019,6 @@ static GLboolean r700TryDrawPrims(GLcontext *ctx,
context_t *context = R700_CONTEXT(ctx);
radeonContextPtr radeon = &context->radeon;
GLuint i, id = 0;
- GLboolean bValidedbuffer;
struct radeon_renderbuffer *rrb;
if (ctx->NewState)
@@ -1027,7 +1026,13 @@ static GLboolean r700TryDrawPrims(GLcontext *ctx,
_mesa_update_state( ctx );
}
- bValidedbuffer = r600ValidateBuffers(ctx);
+ _tnl_UpdateFixedFunctionProgram(ctx);
+ r700SetVertexFormat(ctx, arrays, max_index + 1);
+ r700SetupIndexBuffer(ctx, ib);
+ /* shaders need to be updated before buffers are validated */
+ r700UpdateShaders2(ctx);
+ if (!r600ValidateBuffers(ctx))
+ return GL_FALSE;
/* always emit CB base to prevent
* lock ups on some chips.
@@ -1036,34 +1041,28 @@ static GLboolean r700TryDrawPrims(GLcontext *ctx,
/* mark vtx as dirty since it changes per-draw */
R600_STATECHANGE(context, vtx);
- _tnl_UpdateFixedFunctionProgram(ctx);
- r700SetVertexFormat(ctx, arrays, max_index + 1);
- r700SetupStreams2(ctx, arrays, max_index + 1);
- r700UpdateShaders2(ctx);
-
r700SetScissor(context);
-
r700SetupVertexProgram(ctx);
-
r700SetupFragmentProgram(ctx);
-
r600UpdateTextureState(ctx);
GLuint emit_end = r700PredictRenderSize(ctx, nr_prims)
+ context->radeon.cmdbuf.cs->cdw;
- r700SetupIndexBuffer(ctx, ib);
+ r700SetupStreams2(ctx, arrays, max_index + 1);
radeonEmitState(radeon);
- for (i = 0; i < nr_prims; ++i)
+ radeon_debug_add_indent();
+ for (i = 0; i < nr_prims; ++i)
{
- r700RunRenderPrimitive(ctx,
- prim[i].start,
- prim[i].start + prim[i].count,
+ r700RunRenderPrimitive(ctx,
+ prim[i].start,
+ prim[i].start + prim[i].count,
prim[i].mode);
}
-
+ radeon_debug_remove_indent();
+
/* Flush render op cached for last several quads. */
r700WaitForIdleClean(context);