diff options
author | Kenneth Graunke <[email protected]> | 2014-05-14 01:07:32 -0700 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2014-05-18 23:35:20 -0700 |
commit | 25f8fbbf2fc74470f7edce7cae25453a3edbdfe0 (patch) | |
tree | ee30c613317bcec57313aebc166437cfb1b6fe74 /src/mesa/drivers/dri/i965/brw_wm.h | |
parent | 81b11bf0934d5387bd3741b6268501df3973a6a7 (diff) |
i965/fs: Use 'c' as the mem_ctx in fs_visitor.
Previously, the memory context situation was a bit of a mess:
fs_visitor allocated its own memory context, and freed it in the
destructor. However, some data produced by fs_visitor (such as the list
of instructions) needs to live beyond when fs_visitor is "done", so the
caller can pass it to fs_generator.
Everything worked out because brw_wm_fs_emit's fs_visitor variables
happen to not go out of scope until the end of the function. But that
meant that moving the declaration of, say, the SIMD16 fs_visitor
instance, could cause everything to explode.
Using a memory context that exists for the duration of the compile is
clearer, and should be equivalent.
Ultimately, we don't want to use 'c', but this matches the behavior of
fs_generator and gen8_fs_generator, so it'll be simple to change later.
Signed-off-by: Kenneth Graunke <[email protected]>
Reviewed-by: Chris Forbes <[email protected]>
Diffstat (limited to 'src/mesa/drivers/dri/i965/brw_wm.h')
0 files changed, 0 insertions, 0 deletions