diff options
author | Carl Worth <[email protected]> | 2013-01-11 07:15:18 -0800 |
---|---|---|
committer | Carl Worth <[email protected]> | 2013-01-14 15:35:37 -0800 |
commit | 258453716f001eab1288d99765213221d0599ca4 (patch) | |
tree | 87d586d066e1a84d2b5b739b7a897a3e09c2be74 /src/mesa/drivers/dri/i965/brw_util.h | |
parent | 6d4d4b00ddfbd3257ecd129fec5b813be7e36fe9 (diff) |
i965: Avoid blending with destination alpha when RB format has no alpha bits
The hardware does not support a render target without an alpha channel.
So when the user creates a render buffer with no alpha channel, there actually
is storage available for alpha internally. It requires special care to
avoid these unwanted alpha bits from causing any problems.
Specifically, when blending, and when the blend factors would read the
destination alpha values, this commit coerces the blend factors to instead be
either 0 or 1 as appropriate.
A similar fix was made for pre-gen6 hardware in commit eadd9b8e and this
commit shares the fixup function written by Ian then.
This commit the following es3conform test:
rgb8_rgba8_rgb
As well as the following piglit (sub) tests:
EXT_framebuffer_object/fbo-blending-formats/3
EXT_framebuffer_object/fbo-blending-formats/GL_RGB
EXT_framebuffer_object/fbo-blending-formats/GL_RGB8
Reviewed-by: Ian Romanick <[email protected]>
Diffstat (limited to 'src/mesa/drivers/dri/i965/brw_util.h')
-rw-r--r-- | src/mesa/drivers/dri/i965/brw_util.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_util.h b/src/mesa/drivers/dri/i965/brw_util.h index c0fc1330e4b..5cba99a9306 100644 --- a/src/mesa/drivers/dri/i965/brw_util.h +++ b/src/mesa/drivers/dri/i965/brw_util.h @@ -39,7 +39,6 @@ extern GLuint brw_parameter_list_state_flags(struct gl_program_parameter_list *paramList); extern GLuint brw_translate_blend_factor( GLenum factor ); extern GLuint brw_translate_blend_equation( GLenum mode ); - - +extern GLenum brw_fix_xRGB_alpha(GLenum function); #endif |