diff options
author | Francisco Jerez <[email protected]> | 2016-09-01 00:35:03 -0700 |
---|---|---|
committer | Francisco Jerez <[email protected]> | 2016-09-14 14:50:57 -0700 |
commit | 80e1d670b4b4c080ce2092a3b52d2415bc4c6a42 (patch) | |
tree | 3194521aa314a5bcd70780bedae8e7fc40718e29 /src/mesa/drivers/common | |
parent | 8e58e4412f97be9c3b07d7a7d72d3884606411a2 (diff) |
i965/fs: Get rid of fs_inst::set_smear().
component() was generally a better alternative because of several
issues set_smear() had:
- It wouldn't take the original stride and offset of the register
into account, which means that set_smear() on the result of
e.g. another set_smear() call or an offset() call would give a
bogus region as result.
- It was an inherently destructive operation. See the
'nir_intrinsic_shader_clock' hunk below for how this could lead to
subtle bugs in cases where set_smear() was called multiple times on
the same register like 'r.set_smear(0), r.set_smear(1)' with the
expectation that each call would return a separate value instead of
a reference to the same subsequently mutated object.
Reviewed-by: Iago Toral Quiroga <[email protected]>
Diffstat (limited to 'src/mesa/drivers/common')
0 files changed, 0 insertions, 0 deletions