summaryrefslogtreecommitdiffstats
path: root/src/mesa/drivers/common/meta.c
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2015-02-26 17:45:49 -0800
committerKenneth Graunke <[email protected]>2015-03-09 16:07:04 -0700
commite95969cd9548033250ba12f2adf11740319b41e7 (patch)
treed2cd232de34360b71755ce23329851d281ba2dbf /src/mesa/drivers/common/meta.c
parent4ebeb71573ad44f7657810dc5dd2c9030e3e63db (diff)
i965/fs: Don't issue FB writes for bound but unwritten color targets.
We used to loop over all color attachments, and emit FB writes for each one, even if the shader didn't write to a corresponding output variable. Those color attachments would be filled with garbage (undefined values). Football Manager binds a framebuffer with 4 color attachments, but draws to it using a shader that only writes to gl_FragData[0..2]. This meant that color attachment 3 would be filled with garbage, resulting in rendering artifacts. Now we skip writing to it, fixing rendering. Writes to gl_FragColor initialize outputs[0..nr_color_regions-1] to GRFs, while writes to gl_FragData[i] initialize outputs[i]. Thanks to Jason Ekstrand for tracking this down. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86747 Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]> Cc: [email protected]
Diffstat (limited to 'src/mesa/drivers/common/meta.c')
0 files changed, 0 insertions, 0 deletions