summaryrefslogtreecommitdiffstats
path: root/src/intel
diff options
context:
space:
mode:
authorKai Wasserbäch <[email protected]>2018-08-25 12:00:30 +0200
committerLionel Landwerlin <[email protected]>2018-08-25 16:52:12 +0100
commitb2313ef4a887e11b2008f9109e3741b7def88370 (patch)
tree802f06f257f779807841ea25f5696713e2dd2a66 /src/intel
parent70de31d0c106f58d6b7e6d5b79b8d90c1c112a3b (diff)
intel: tools: Fix aubinator_error's fprintf call (format-security)
The recent commit 4616639b49b4bbc91e503c1c27632dccc1c2b5be introduced the new function aubinator_error() which is a trivial wrapper around fprintf() to STDERR. The call to fprintf() however is passed the message msg directly: fprintf(stderr, msg); This is a format-security violation and leads to an FTBFS with -Werror=format-security (GCC 8): ../../../src/intel/tools/aubinator.c: In function 'aubinator_error': ../../../src/intel/tools/aubinator.c:74:4: error: format not a string literal and no format arguments [-Werror=format-security] fprintf(stderr, msg); ^~~~~~~ This patch fixes this trivially by introducing a catch-all "%s" format argument. Fixes: 4616639b49b ("intel: tools: split aub parsing from aubinator") Cc: Lionel Landwerlin <[email protected]> Signed-off-by: Kai Wasserbäch <[email protected]> Reviewed-by: Lionel Landwerlin <[email protected]>
Diffstat (limited to 'src/intel')
-rw-r--r--src/intel/tools/aubinator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 374ed46f864..c22d191f146 100644
--- a/src/intel/tools/aubinator.c
+++ b/src/intel/tools/aubinator.c
@@ -71,7 +71,7 @@ struct brw_instruction;
static void
aubinator_error(void *user_data, const void *aub_data, const char *msg)
{
- fprintf(stderr, msg);
+ fprintf(stderr, "%s", msg);
}
static void