diff options
| author | Ian Romanick <[email protected]> | 2018-06-18 17:02:58 -0700 |
|---|---|---|
| committer | Ian Romanick <[email protected]> | 2018-09-01 00:23:45 -0700 |
| commit | 82530ce1b5a76ce1835ed573411ed26cc2338a3e (patch) | |
| tree | 63bcd80745751976566039c2303cd1306667251b /src/intel | |
| parent | 75666605c98e628ad6a88ef46ec7351588969ed5 (diff) | |
i965/vec4: Clamp indirect tes input array reads with 0x0fffffff
Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the valid
range of the offset is [0, 0FFFFFFFh].
Signed-off-by: Ian Romanick <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Cc: [email protected]
Diffstat (limited to 'src/intel')
| -rw-r--r-- | src/intel/compiler/brw_vec4_tes.cpp | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/src/intel/compiler/brw_vec4_tes.cpp b/src/intel/compiler/brw_vec4_tes.cpp index 35aff0f4b78..cf1bff42aa9 100644 --- a/src/intel/compiler/brw_vec4_tes.cpp +++ b/src/intel/compiler/brw_vec4_tes.cpp @@ -185,9 +185,19 @@ vec4_tes_visitor::nir_emit_intrinsic(nir_intrinsic_instr *instr) first_component /= 2; if (indirect_offset.file != BAD_FILE) { + src_reg clamped_indirect_offset = src_reg(this, glsl_type::uvec4_type); + + /* Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the + * valid range of the offset is [0, 0FFFFFFFh]. + */ + emit_minmax(BRW_CONDITIONAL_L, + dst_reg(clamped_indirect_offset), + retype(indirect_offset, BRW_REGISTER_TYPE_UD), + brw_imm_ud(0x0fffffffu)); + header = src_reg(this, glsl_type::uvec4_type); emit(TES_OPCODE_ADD_INDIRECT_URB_OFFSET, dst_reg(header), - input_read_header, indirect_offset); + input_read_header, clamped_indirect_offset); } else { /* Arbitrarily only push up to 24 vec4 slots worth of data, * which is 12 registers (since each holds 2 vec4 slots). |