diff options
| author | Matt Turner <[email protected]> | 2017-06-30 14:58:22 -0700 |
|---|---|---|
| committer | Matt Turner <[email protected]> | 2017-07-20 16:56:49 -0700 |
| commit | 823893051052c55baece54449ba1f7c2669f4d33 (patch) | |
| tree | 2ad6ecc717c388a7a3c1f213beb42fd013531148 /src/intel/compiler | |
| parent | f1b7c47913344338a8730cf3561ce95527b53c4c (diff) | |
i965/fs: Do not move MOVs writing the flag outside of control flow
The implementation of ballotARB() will start by zeroing the flags
register. So, a doing something like
if (gl_SubGroupInvocationARB % 2u == 0u) {
... = ballotARB(true);
[...]
} else {
... = ballotARB(true);
[...]
}
(like fs-ballot-if-else.shader_test does) would generate identical MOVs
to the same destination (the flag register!), and we definitely do not
want to pull that out of the control flow.
Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/intel/compiler')
| -rw-r--r-- | src/intel/compiler/brw_fs_sel_peephole.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/intel/compiler/brw_fs_sel_peephole.cpp b/src/intel/compiler/brw_fs_sel_peephole.cpp index 8cd897f72e0..fd02792bebc 100644 --- a/src/intel/compiler/brw_fs_sel_peephole.cpp +++ b/src/intel/compiler/brw_fs_sel_peephole.cpp @@ -68,7 +68,8 @@ count_movs_from_if(fs_inst *then_mov[MAX_MOVS], fs_inst *else_mov[MAX_MOVS], { int then_movs = 0; foreach_inst_in_block(fs_inst, inst, then_block) { - if (then_movs == MAX_MOVS || inst->opcode != BRW_OPCODE_MOV) + if (then_movs == MAX_MOVS || inst->opcode != BRW_OPCODE_MOV || + inst->flags_written()) break; then_mov[then_movs] = inst; @@ -77,7 +78,8 @@ count_movs_from_if(fs_inst *then_mov[MAX_MOVS], fs_inst *else_mov[MAX_MOVS], int else_movs = 0; foreach_inst_in_block(fs_inst, inst, else_block) { - if (else_movs == MAX_MOVS || inst->opcode != BRW_OPCODE_MOV) + if (else_movs == MAX_MOVS || inst->opcode != BRW_OPCODE_MOV || + inst->flags_written()) break; else_mov[else_movs] = inst; |