summaryrefslogtreecommitdiffstats
path: root/src/intel/blorp/TODO
diff options
context:
space:
mode:
authorMatt Turner <[email protected]>2019-10-16 12:45:55 -0700
committerMatt Turner <[email protected]>2019-10-30 11:11:50 -0700
commitded9fb2b18b114d311a5425916b64a12fb7ff36b (patch)
tree2e30659589280958bc786f52f50c997202443391 /src/intel/blorp/TODO
parentfa3baeab76dadeb61b7edfc849b6c5d379cc358a (diff)
intel/compiler: Remove unreachable() from brw_reg_type.c
The EU compaction unit test fuzzes the compaction code by flipping bits. We use a simple skip_bits() function with a list of reserved bits to ignore, but for more complex cases like invalid combinations of register file:type, we need either machinery to check validity or for these functions to simply inform us whether a combination was valid. enum brw_reg_type a 4-bit field in brw_reg, so rather than expanding it with an "INVALID" value, just return -1 and let the caller check for that. Scott suggested redefining unreachable() within the unit test to longjmp() which would allow driver code like this to still use it and allow the test to handle expected failures like this. If that plan works out, I plan to revert this.
Diffstat (limited to 'src/intel/blorp/TODO')
0 files changed, 0 insertions, 0 deletions