diff options
author | Chad Versace <[email protected]> | 2017-08-25 14:14:34 -0700 |
---|---|---|
committer | Chad Versace <[email protected]> | 2017-10-17 11:08:26 -0700 |
commit | aa716db0f64ddb60da17ed64cfcf1248b9ddf907 (patch) | |
tree | 69cf9a920a3497c330b97fd168fe31ab45fb613a /src/intel/Makefile.sources | |
parent | 3555d3613958f6845e2172dfe8ecf842c1d77687 (diff) |
intel: Add simple logging façade for Android (v2)
I'm bringing up Vulkan in the Android container of Chrome OS (ARC++).
On Android, stdio goes to /dev/null. On Android, remote gdb is even more
painful than the usual remote gdb. On Android, nothing works like you
expect and debugging is hell. I need logging.
This patch introduces a small, simple logging API that can easily wrap
Android's API. On non-Android platforms, this logger does nothing fancy.
It follows the time-honored Unix tradition of spewing everything to
stderr with minimal fuss.
My goal here is not perfection. My goal is to make a minimal, clean API,
that people hate merely a little instead of a lot, and that's good
enough to let me bring up Android Vulkan. And it needs to be fast,
which means it must be small. No one wants to their game to miss frames
while aiming a flaming bow into the jaws of an angry robot t-rex, and
thus become t-rex breakfast, because some fool had too much fun desiging
a bloated, ideal logging API.
If people like it, perhaps we should quickly promote it to src/util.
The API looks like this:
#define INTEL_LOG_TAG "intel-vulkan"
#define DEBUG
intel_logd("try hard thing with foo=%d", foo);
n = try_foo(...);
if (n < 0) {
intel_loge("%s:%d: foo failed bigtime", __FILE__, __LINE__);
return VK_ERROR_DEVICE_LOST;
}
And produces this on non-Android:
intel-vulkan: debug: try hard thing with foo=93
intel-vulkan: error: anv_device.c:182: foo failed bigtime
v2: Fix meson build. [for dcbaker]
Reviewed-by: Jason Ekstrand <[email protected]>
Diffstat (limited to 'src/intel/Makefile.sources')
-rw-r--r-- | src/intel/Makefile.sources | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/intel/Makefile.sources b/src/intel/Makefile.sources index b8355337f83..da018dcc6a4 100644 --- a/src/intel/Makefile.sources +++ b/src/intel/Makefile.sources @@ -18,7 +18,9 @@ COMMON_FILES = \ common/gen_l3_config.c \ common/gen_l3_config.h \ common/gen_urb_config.c \ - common/gen_sample_positions.h + common/gen_sample_positions.h \ + common/intel_log.c \ + common/intel_log.h COMPILER_FILES = \ compiler/brw_cfg.cpp \ |