diff options
author | Iago Toral Quiroga <[email protected]> | 2018-04-02 11:39:41 +0200 |
---|---|---|
committer | Iago Toral Quiroga <[email protected]> | 2018-04-04 07:57:58 +0200 |
commit | 41ac0b1443ca7c8c3481eab978a41b7caba5503a (patch) | |
tree | e2d5544e146cb19a089e02d376bf4ca3d1510bde /src/intel/Android.common.mk | |
parent | 98b860e3115ff937152dbf4c843e1ecb9244734c (diff) |
compiler/spirv: set is_shadow for depth comparitor sampling opcodes
From the SPIR-V spec, OpTypeImage:
"Depth is whether or not this image is a depth image. (Note that
whether or not depth comparisons are actually done is a property of
the sampling opcode, not of this type declaration.)"
The sampling opcodes that specify depth comparisons are
OpImageSample{Proj}Dref{Explicit,Implicit}Lod, so we should set
is_shadow only for these (we were using the deph property of the
image until now).
v2:
- Do the same for OpImageDrefGather.
- Set is_shadow to false if the sampling opcode is not one of these (Jason)
- Reuse an existing switch statement instead of adding a new one (Jason)
Fixes crashes in:
dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.depth_property.*
Reviewed-by: Jason Ekstrand <[email protected]>
Cc: [email protected]
Diffstat (limited to 'src/intel/Android.common.mk')
0 files changed, 0 insertions, 0 deletions