diff options
author | Roland Scheidegger <[email protected]> | 2016-11-13 16:33:37 +0100 |
---|---|---|
committer | Roland Scheidegger <[email protected]> | 2016-11-21 20:02:53 +0100 |
commit | e442db8e9821d210df0a2f253d7b47bfad23a3bf (patch) | |
tree | 10a63acaf654e8523cfbd6e1b56848af29a2ad2b /src/glx/glxcurrent.c | |
parent | 2471aaa02fc2be0f5fea2df7c7ae6af3aab16b26 (diff) |
draw: drop some overflow computations
It turns out that noone actually cares if the address computations overflow,
be it the stride mul or the offset adds.
Wrap around seems to be explicitly permitted even by some other API (which
is a _very_ surprising result, as these overflow computations were added just
for that and made some tests pass at that time - I suspect some later fixes
fixed the actual root cause...). So the requirements in that other api were
actually sane there all along after all...
Still need to make sure the computed buffer size needed is valid, of course.
This ditches the shiny new widening mul from these codepaths, ah well...
And now that I really understand this, change the fishy min limiting
indices to what it really should have done. Which is simply to prevent
fetching more values than valid for the last loop iteration. (This makes
the code path in the loop minimally more complex for the non-indexed case
as we have to skip the optimization combining two adds. I think it should
be safe to skip this actually there, but I don't care much about this
especially since skipping that optimization actually makes the code easier
to read elsewhere.)
Reviewed-by: Jose Fonseca <[email protected]>
Diffstat (limited to 'src/glx/glxcurrent.c')
0 files changed, 0 insertions, 0 deletions