diff options
author | Ian Romanick <ian.d.romanick@intel.com> | 2013-10-02 16:19:59 -0700 |
---|---|---|
committer | Ian Romanick <ian.d.romanick@intel.com> | 2013-10-22 15:23:30 -0700 |
commit | 78b70ceae1c0155b3f832cb052dfb6fff3530ff4 (patch) | |
tree | efc43a5f6f8ad624678d13c306ee77eae36ef6c3 /src/glsl/tests/.gitignore | |
parent | 09ceed75872e15b175e362f8d0ea146a8c79ae08 (diff) |
glsl: When constructing a variable with an interface type, set interface_type
Ever since the addition of interface blocks with instance names, we have
had an implicit invariant:
var->type->is_interface() ==
(var->type == var->interface_type)
The odd use of == here is intentional because !var->type->is_interface()
implies var->type != var->interface_type.
Further, if var->type->is_array() is true, we have a related implicit
invariant:
var->type->fields.array->is_interface() ==
(var->type->fields.array == var->interface_type)
However, the ir_variable constructor doesn't maintain either invariant.
That seems kind of silly... and I tripped over it while writing some
other code. This patch makes the constructor do the right thing, and it
introduces some tests to verify that behavior.
v2: Add general-ir-test to .gitignore. Update the description of the
ir_variable invariant for arrays in the commit message. Both suggested
by Paul.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Paul Berry <stereotype441@gmail.com>
Diffstat (limited to 'src/glsl/tests/.gitignore')
-rw-r--r-- | src/glsl/tests/.gitignore | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/glsl/tests/.gitignore b/src/glsl/tests/.gitignore index de81adf044c..15ce248a274 100644 --- a/src/glsl/tests/.gitignore +++ b/src/glsl/tests/.gitignore @@ -1,3 +1,4 @@ ralloc-test uniform-initializer-test sampler-types-test +general-ir-test |