diff options
| author | Jason Ekstrand <[email protected]> | 2014-12-17 15:34:47 -0800 |
|---|---|---|
| committer | Jason Ekstrand <[email protected]> | 2015-01-15 07:20:23 -0800 |
| commit | 1b720c6ed868b3f231f63568fc360fe7c4024c02 (patch) | |
| tree | cf1ebcac20b2dd139feed7fc037bf38af4fba9df /src/glsl/nir/nir.c | |
| parent | de73d1e17318b9e7ed9d1f84bef56f6cc09bdf82 (diff) | |
nir/from_ssa: Clean up parallel copy handling and document it better
Previously, we were doing a lazy creation of the parallel copy
instructions. This is confusing, hard to get right, and involves some
extra state tracking of the copies. This commit adds an extra walk over
the basic blocks to add the block-end parallel copies up front. This
should be much less confusing and, consequently, easier to get right. This
commit also adds more comments about parallel copies to help explain what
all is going on.
As a consequence of these changes, we can now remove the at_end parameter
from nir_parallel_copy_instr.
Reviewed-by: Connor Abbott <[email protected]>
Diffstat (limited to 'src/glsl/nir/nir.c')
| -rw-r--r-- | src/glsl/nir/nir.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 4b02ec0dd86..eeed6f2aa9d 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -474,7 +474,6 @@ nir_parallel_copy_instr_create(void *mem_ctx) nir_parallel_copy_instr *instr = ralloc(mem_ctx, nir_parallel_copy_instr); instr_init(&instr->instr, nir_instr_type_parallel_copy); - instr->at_end = false; exec_list_make_empty(&instr->copies); return instr; |