diff options
author | Roland Scheidegger <[email protected]> | 2013-06-01 02:17:09 +0200 |
---|---|---|
committer | Roland Scheidegger <[email protected]> | 2013-06-01 20:03:59 +0200 |
commit | 458a9a0f85b93e3520c33dd3b502e26a31f08e4b (patch) | |
tree | 2721267f4483f28f2e1f9c1d0e96fcb8104fab93 /src/glsl/loop_controls.cpp | |
parent | f51fc7a71c272ad28e157d1d8f642649c3b5487b (diff) |
gallivm: fix out-of-bounds access with mirror_clamp_to_edge address mode
Surprising this bug survived so long, we were missing a clamp (in the
linear filtering version).
(Valgrind complained a lot about invalid reads with piglit texwrap,
I've also seen spurios failures in this test which might have
happened due to this. Valgrind probably didn't complain before the
alignment reduction in llvmpipe to 4x4 since the test is using tiny
textures so the reads were still always well within allocated area.)
While here, also do an effective clamp (after half subtraction)
of [0,length-0.5] instead of [0, length-1] which saves an instruction
(the filtering weight could be different due to this, but only if
both texels point to the same max texel so it doesn't matter).
(Both changes are borrowed from PIPE_TEX_CLAMP_TO_EDGE case.)
Note: This is a candidate for the stable branches.
Reviewed-by: Jose Fonseca <[email protected]>
Diffstat (limited to 'src/glsl/loop_controls.cpp')
0 files changed, 0 insertions, 0 deletions