summaryrefslogtreecommitdiffstats
path: root/src/glsl/linker.cpp
diff options
context:
space:
mode:
authorPaul Berry <[email protected]>2011-08-03 16:16:59 -0700
committerPaul Berry <[email protected]>2011-08-08 12:43:57 -0700
commit01a851c296347d8e9d2166b3c83eab97404c0670 (patch)
treeaf393aa8d349fe39dc1977909cc689a60671555f /src/glsl/linker.cpp
parentd4144a123b603d3c33cb356cf3c8e5ae4653594e (diff)
glsl: When linking, emit functions at the tail of the final linked program.
When link_functions.cpp adds a new function to the final linked program, it needs to add it after any global variable declarations that the function refers to, otherwise the IR will be invalid (because variable declarations must occur before variable accesses). The easiest way to do that is to have the linker emit functions to the tail of the final linked program. The linker used to emit functions to the head of the final linked program, in an effort to keep callees sorted before their callers. However, this was not reliable: it didn't work for functions declared or defined in the same compilation unit as main, for diamond-shaped patterns in the call graph, or for some obscure cases involving overloaded functions. And no code currently relies on this sort order. No Piglit regressions with i965 Ironlake. Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/glsl/linker.cpp')
0 files changed, 0 insertions, 0 deletions