summaryrefslogtreecommitdiffstats
path: root/src/glsl/link_functions.cpp
diff options
context:
space:
mode:
authorFrancisco Jerez <[email protected]>2015-07-13 15:40:18 +0300
committerFrancisco Jerez <[email protected]>2015-07-29 14:12:46 +0300
commitf68ec2baf49e37f9ce4fffe95f13177eb7225015 (patch)
tree2d6b62c13907c201dca199a1d92d1324bccdebfa /src/glsl/link_functions.cpp
parentfa75f2d56616cba81014d4fc02931dcfaedaf5b9 (diff)
i965/fs: Make sure that the type sizes are compatible during copy propagation.
It's surprising that we weren't checking for this already. A future patch will cause code like the following to be emitted: MOV(16) tmp<1>:uw, src MOV(8) dst<1>:ud, tmp<8,8,1>:ud The second MOV comes from the expansion of a LOAD_PAYLOAD header copy, so I don't have control over its types. Copy propagation will happily turn this into: MOV(8) dst<1>:ud, src Which has different semantics. Fix it by preventing propagation in cases where a single channel of the instruction would span several channels of the copy (this requirement could in fact be relaxed if the copy is just a trivial memcpy, but this case is unusual enough that I don't think it matters in practice). I'm deliberately only checking if the type of the instruction is larger than the original, because the converse case seems to be handled correctly already in the code below. Reviewed-by: Jason Ekstrand <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/glsl/link_functions.cpp')
0 files changed, 0 insertions, 0 deletions