summaryrefslogtreecommitdiffstats
path: root/src/glsl/ir_print_visitor.h
diff options
context:
space:
mode:
authorKenneth Graunke <[email protected]>2011-09-22 15:04:56 -0700
committerKenneth Graunke <[email protected]>2012-04-02 14:15:34 -0700
commit807e967c615dc80a264af5a89af7649f95481744 (patch)
treebc95060bdeba0fac02a0183f3b21f9e0119389b9 /src/glsl/ir_print_visitor.h
parentac0f8bae8d39ca9f5e873ba8411472e2962890cd (diff)
glsl: Use ir_rvalue to represent generic error_type values.
Currently, ir_call can be used as either a statement (for void functions) or a value (for non-void functions). This is rather awkward, as it's the only class that can be used in both forms. A number of places use ir_call::get_error_instruction() to construct a generic value of error_type. If ir_call is to become a statement, it can no longer serve this purpose. Unfortunately, none of our classes are particularly well suited for this, and creating a new one would be rather aggrandizing. So, this patch introduces ir_rvalue::error_value(), a static method that creates an instance of the base class, ir_rvalue. This has the nice property that you can't accidentally try and access uninitialized fields (as it doesn't have any). The downside is that the base class is no longer abstract. Signed-off-by: Kenneth Graunke <[email protected]> Reviewed-by: Eric Anholt <[email protected]> Reviewed-by: Ian Romanick <[email protected]>
Diffstat (limited to 'src/glsl/ir_print_visitor.h')
-rw-r--r--src/glsl/ir_print_visitor.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/glsl/ir_print_visitor.h b/src/glsl/ir_print_visitor.h
index c7136f11a3b..6c308f31e95 100644
--- a/src/glsl/ir_print_visitor.h
+++ b/src/glsl/ir_print_visitor.h
@@ -54,6 +54,7 @@ public:
* the hierarchy should not have \c visit methods.
*/
/*@{*/
+ virtual void visit(ir_rvalue *);
virtual void visit(ir_variable *);
virtual void visit(ir_function_signature *);
virtual void visit(ir_function *);