summaryrefslogtreecommitdiffstats
path: root/src/glsl/ir_constant_expression.cpp
diff options
context:
space:
mode:
authorPaul Berry <[email protected]>2011-07-12 12:03:02 -0700
committerPaul Berry <[email protected]>2011-07-18 10:48:27 -0700
commitf07221056e1822187546b76387714b3172f9b2c5 (patch)
tree7682a4551154360bc607b2d86755c7600bfb18f7 /src/glsl/ir_constant_expression.cpp
parentddc1c96390b685bb95f7431e862c3a64fcefa085 (diff)
glsl: Ensure that sampler declarations are always uniform or "in" parameters.
This brings us into compliance with page 17 (page 22 of the PDF) of the GLSL 1.20 spec: "[Sampler types] can only be declared as function parameters or uniform variables (see Section 4.3.5 "Uniform"). ... [Samplers] cannot be used as out or inout function parameters." The spec isn't explicit about whether this rule applies to structs/arrays containing shaders, but the intent seems to be to ensure that it can always be determined at compile time which sampler is being used in each texture lookup. So to avoid creating a loophole, the rule needs to apply to structs/arrays containing shaders as well. Fixes piglit tests spec/glsl-1.10/compiler/samplers/*.frag, and fixes bug 38987. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38987 Reviewed-by: Ian Romanick <[email protected]>
Diffstat (limited to 'src/glsl/ir_constant_expression.cpp')
0 files changed, 0 insertions, 0 deletions