diff options
| author | Ian Romanick <[email protected]> | 2014-07-14 15:48:38 -0700 |
|---|---|---|
| committer | Kenneth Graunke <[email protected]> | 2014-08-29 23:29:19 -0700 |
| commit | 932b0ef1ceecf873213447a8778e5cbe1b3b6be7 (patch) | |
| tree | e0925b8001889ad75902abe9c5d2d740b8883b5d /src/glsl/ir.h | |
| parent | 8eeca7a56cf1ef47b6f86cc5a0397a532a7c2932 (diff) | |
glsl: Use bit-flags image attributes and uint16_t for the image format
All of the GL image enums fit in 16-bits.
Also move the fields from the anonymous "image" structucture to the next
higher structure. This will enable packing the bits with the other
bitfield.
Valgrind massif results for a trimmed apitrace of dota2:
n time(i) total(B) useful-heap(B) extra-heap(B) stacks(B)
Before (32-bit): 76 40,572,916,873 68,831,248 63,328,783 5,502,465 0
After (32-bit): 70 40,577,421,777 68,487,584 62,973,695 5,513,889 0
Before (64-bit): 60 36,822,640,058 96,526,824 88,735,296 7,791,528 0
After (64-bit): 74 37,124,603,758 95,891,808 88,466,712 7,425,096 0
A real savings of 346KiB on 32-bit and 262KiB on 64-bit.
Signed-off-by: Ian Romanick <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/glsl/ir.h')
| -rw-r--r-- | src/glsl/ir.h | 27 |
1 files changed, 13 insertions, 14 deletions
diff --git a/src/glsl/ir.h b/src/glsl/ir.h index 5032c2610fa..e9051732bcc 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -697,6 +697,19 @@ public: */ unsigned index:1; + + /** + * ARB_shader_image_load_store qualifiers. + */ + unsigned image_read_only:1; /**< "readonly" qualifier. */ + unsigned image_write_only:1; /**< "writeonly" qualifier. */ + unsigned image_coherent:1; + unsigned image_volatile:1; + unsigned image_restrict:1; + + /** Image internal format if specified explicitly, otherwise GL_NONE. */ + uint16_t image_format; + /** * \brief Layout qualifier for gl_FragDepth. * @@ -745,20 +758,6 @@ public: } atomic; /** - * ARB_shader_image_load_store qualifiers. - */ - struct { - bool read_only; /**< "readonly" qualifier. */ - bool write_only; /**< "writeonly" qualifier. */ - bool coherent; - bool _volatile; - bool restrict_flag; - - /** Image internal format if specified explicitly, otherwise GL_NONE. */ - GLenum format; - } image; - - /** * Highest element accessed with a constant expression array index * * Not used for non-array variables. |