diff options
author | Paul Berry <[email protected]> | 2013-07-31 10:57:22 -0700 |
---|---|---|
committer | Paul Berry <[email protected]> | 2013-08-01 20:19:35 -0700 |
commit | 1c789d8087327203d3dcf5c140bf9d9c65b86086 (patch) | |
tree | 2cd9aec625f1e9957ca8ceb982b140e5bc9cd70a /src/glsl/ir.cpp | |
parent | d5a333a06f4dd8e084666e82019dde7cb40f9643 (diff) |
glsl: Fallback gracefully if ir_set_program_inouts sees unexpected indexing.
The code in ir_set_program_inouts that marks just a portion of a
variable as used (rather than the whole variable) only works on a few
kinds of indexing operations:
- Indexing into matrices
- Indexing into arrays of matrices, vectors, or scalars.
Fortunately these are the only kinds of indexing operations that we
expect to see; everything else is either handled by a
previously-executed lowering pass or prohibited by GLSL.
However, that could conceivably change in the future (the GLSL rules
might change, or we might modify the lowering passes). To avoid
mysterious bugs in the future, let's have ir_set_program_inouts report
an assertion failure if it ever encounters an unexpected kind of
indexing operation (and in release builds, fall back to just marking
the whole variable as used).
Reviewed-by: Ian Romanick <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/glsl/ir.cpp')
0 files changed, 0 insertions, 0 deletions