summaryrefslogtreecommitdiffstats
path: root/src/glsl/builtins
diff options
context:
space:
mode:
authorPaul Berry <[email protected]>2013-03-29 13:34:51 -0700
committerPaul Berry <[email protected]>2013-04-02 12:24:08 -0700
commit7d4f1e6467a1b28ea6b0453ef9cd0254b3d57c19 (patch)
tree6562d56e7676ce280c6131e96527cb035b46da12 /src/glsl/builtins
parent450950c57ac53d80a1c57f8ef5eb365db300fec2 (diff)
glsl: Fix array indexing when constant folding built-in functions.
Mesa constant-folds built-in functions by using a miniature GLSL interpreter (see ir_function_signature::constant_expression_evaluate_expression_list()). This interpreter had a bug in its handling of array indexing, which caused expressions like "m[i][j]" (where m is a matrix) to be handled incorrectly. Specifically, it incorrectly treated j as indexing into the whole matrix (rather than indexing just into the vector m[i]); as a result the offset computed for m[i] was lost and m[i][j] was treated as m[j][0]. Fixes piglit tests inverse-mat[234].{vert,frag}. NOTE: This is a candidate for the 9.1 and 9.0 branches. Reviewed-by: Ian Romanick <[email protected]> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57436
Diffstat (limited to 'src/glsl/builtins')
0 files changed, 0 insertions, 0 deletions