diff options
author | Ian Romanick <[email protected]> | 2013-08-30 14:04:18 -0700 |
---|---|---|
committer | Ian Romanick <[email protected]> | 2013-09-04 08:02:23 -0700 |
commit | 87252bf97b62bd536632978b9d53e4025b7db77d (patch) | |
tree | 03ceb27258063b295a218cf23072d22d0ed1eda3 /src/glsl/ast_function.cpp | |
parent | 51a279254fecc05691524dab1bf291c7dfefccd5 (diff) |
glsl: Reallow precision qualifiers on structure members
Changes to the grammar for GL_ARB_shading_language_420pack (commit
6eec502) moved precision qualifiers out of the type_specifier production
chain. This caused declarations such as:
struct S {
lowp float f;
};
to generate parse errors. Section 4.1.8 (Structures) of both the GLSL
ES 1.00 spec and GLSL 1.30 specs says:
"Member declarators may contain precision qualifiers, but may not
contain any other qualifiers."
So, it sure seems like we shouldn't generate a parse error. :)
Instead of type_specifier, use fully_specified_type in struct members.
However, fully_specified_type allows a lot of other qualifiers that are
not allowed on structure members, so expeclitly disallow them.
Note, this makes struct_declaration look an awful lot like
member_declaration (used for interface blocks). We may want to
(somehow) unify these rules to reduce code duplication at some point.
Signed-off-by: Ian Romanick <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68753
Reported-by: Aras Pranckevicius <[email protected]>
Cc: Aras Pranckevicius <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Reviewed-by: Matt Turner <[email protected]>
Cc: "9.2" <[email protected]>
Diffstat (limited to 'src/glsl/ast_function.cpp')
0 files changed, 0 insertions, 0 deletions