diff options
author | Iago Toral Quiroga <[email protected]> | 2014-04-04 15:11:15 +0200 |
---|---|---|
committer | Kenneth Graunke <[email protected]> | 2014-04-15 22:18:43 -0700 |
commit | 6d0e30c6a332de9ea7ab00e1fd303df2fb337c64 (patch) | |
tree | ae83bca029160740f6ddfb28258c8e5d61078d43 /src/glsl/TODO | |
parent | 6ac5a5e383830d711793e425ddd285e17ffcd235 (diff) |
glsl: Properly handle blocks that define the same field name.
Currently we can have name space collisions between blocks that define the same
fields. For example:
in block
{
vec4 Color;
} In[];
out block
{
vec4 Color;
} Out;
These two blocks will assign the same interface name (block.Color) to the Color
field in flatten_named_interface_blocks_declarations.cpp, leading to havoc.
This was breaking badly the gl-320-primitive-shading test from ogl-samples.
The patch uses the block instance name to avoid collisions, producing names
like block.In.Color and block.Out.Color to avoid the name clash.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76394
Reviewed-by: Kenneth Graunke <[email protected]>
Diffstat (limited to 'src/glsl/TODO')
0 files changed, 0 insertions, 0 deletions