summaryrefslogtreecommitdiffstats
path: root/src/gallium
diff options
context:
space:
mode:
authorAlexandros Frantzis <[email protected]>2019-05-28 00:06:03 +0300
committerChia-I Wu <[email protected]>2019-06-07 21:45:43 -0700
commite34f79c9182f0beafaec6d254df168515e219568 (patch)
treea1c3e226bb16fd8be94a0cb4780916ccc04c21ad /src/gallium
parent236c55f650d096e63a5de36e66a47a2f46bab5d3 (diff)
virgl: Remove incorrect resource wait condition
Now that we have copy transfers in place, we can remove the incorrect resource wait condition. Copy transfers and other optimizations minimize the performance impact of this removal, while providing the correct behavior. Signed-off-by: Alexandros Frantzis <[email protected]> Reviewed-by: Chia-I Wu <[email protected]>
Diffstat (limited to 'src/gallium')
-rw-r--r--src/gallium/drivers/virgl/virgl_resource.c13
1 files changed, 0 insertions, 13 deletions
diff --git a/src/gallium/drivers/virgl/virgl_resource.c b/src/gallium/drivers/virgl/virgl_resource.c
index 897e0c16c7e..879c3fb359a 100644
--- a/src/gallium/drivers/virgl/virgl_resource.c
+++ b/src/gallium/drivers/virgl/virgl_resource.c
@@ -155,19 +155,6 @@ virgl_resource_transfer_prepare(struct virgl_context *vctx,
flush = true;
}
- /* XXX This is incorrect and will be removed. Consider
- *
- * glTexImage2D(..., data1);
- * glDrawArrays();
- * glFlush();
- * glTexImage2D(..., data2);
- *
- * readback and flush are both false in the second glTexImage2D call. The
- * draw call might end up seeing data2. Same applies to buffers with
- * glBufferSubData.
- */
- wait = flush || readback;
-
if (flush)
vctx->base.flush(&vctx->base, NULL, 0);