diff options
author | Alyssa Rosenzweig <[email protected]> | 2019-05-22 02:41:51 +0000 |
---|---|---|
committer | Alyssa Rosenzweig <[email protected]> | 2019-06-04 20:14:50 +0000 |
commit | 550be763fa0aa9e5a060866963bae216cb1b9db3 (patch) | |
tree | 79d1b33f2987d393249dbd310e7261eec7c4da21 /src/gallium | |
parent | c54f3f42eb3b8544de76e98f74d5e149b808a4f7 (diff) |
panfrost/midgard: Fix liveness analysis bugs
This fixes liveness analysis with respect to inline constants and
branching. in practice, the symptom is abnormally high register
pressure.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Reviewed-by: Ryan Houdek <[email protected]>
Diffstat (limited to 'src/gallium')
-rw-r--r-- | src/gallium/drivers/panfrost/midgard/midgard_liveness.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_liveness.c b/src/gallium/drivers/panfrost/midgard/midgard_liveness.c index ab36583ef39..e4c89556162 100644 --- a/src/gallium/drivers/panfrost/midgard/midgard_liveness.c +++ b/src/gallium/drivers/panfrost/midgard/midgard_liveness.c @@ -31,8 +31,14 @@ static bool midgard_is_live_in_instr(midgard_instruction *ins, int src) { - if (ins->ssa_args.src0 == src) return true; - if (ins->ssa_args.src1 == src) return true; + if (ins->compact_branch) + return false; + + if (ins->ssa_args.src0 == src) + return true; + + if (!ins->ssa_args.inline_constant && ins->ssa_args.src1 == src) + return true; return false; } |