diff options
| author | Paulo Zanoni <[email protected]> | 2020-04-02 16:03:41 -0700 |
|---|---|---|
| committer | Marge Bot <[email protected]> | 2020-04-15 21:35:14 +0000 |
| commit | 2c82b13c8ff63cc296215b6b5991ac00e6f3d495 (patch) | |
| tree | 688824da86165d1571a4cc2120ff7f58ab4d8b7b /src/gallium | |
| parent | 103cb32c794e6428d155d88e42cdf6b9a19b2f31 (diff) | |
iris: make BATCH_SZ smaller by BATCH_RESERVED bytes
Iris allocates gem buffers using buckets of allocation sizes that are
page aligned. We always ask for batch buffers of size BATCH_SZ +
BATCH_RESERVED, which is not page aligned: we ask for 65552 bytes,
which ends up in the bucket of size 81920, resulting in 20% unused
space. Adjust things so there is no waste of space: BATCH_SZ +
BATCH_RESERVED is now 65536.
Reviewed-by: Lionel Landwerlin <[email protected]>
Signed-off-by: Paulo Zanoni <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4561>
Diffstat (limited to 'src/gallium')
| -rw-r--r-- | src/gallium/drivers/iris/iris_batch.c | 6 | ||||
| -rw-r--r-- | src/gallium/drivers/iris/iris_batch.h | 8 |
2 files changed, 7 insertions, 7 deletions
diff --git a/src/gallium/drivers/iris/iris_batch.c b/src/gallium/drivers/iris/iris_batch.c index b0341513f2b..ff0dfd053f4 100644 --- a/src/gallium/drivers/iris/iris_batch.c +++ b/src/gallium/drivers/iris/iris_batch.c @@ -63,12 +63,6 @@ #define FILE_DEBUG_FLAG DEBUG_BUFMGR -/* Terminating the batch takes either 4 bytes for MI_BATCH_BUFFER_END - * or 12 bytes for MI_BATCH_BUFFER_START (when chaining). Plus, we may - * need an extra 4 bytes to pad out to the nearest QWord. So reserve 16. - */ -#define BATCH_RESERVED 16 - static void iris_batch_reset(struct iris_batch *batch); diff --git a/src/gallium/drivers/iris/iris_batch.h b/src/gallium/drivers/iris/iris_batch.h index d8399d3cd34..056a2469191 100644 --- a/src/gallium/drivers/iris/iris_batch.h +++ b/src/gallium/drivers/iris/iris_batch.h @@ -38,8 +38,14 @@ /* The kernel assumes batchbuffers are smaller than 256kB. */ #define MAX_BATCH_SIZE (256 * 1024) +/* Terminating the batch takes either 4 bytes for MI_BATCH_BUFFER_END + * or 12 bytes for MI_BATCH_BUFFER_START (when chaining). Plus, we may + * need an extra 4 bytes to pad out to the nearest QWord. So reserve 16. + */ +#define BATCH_RESERVED 16 + /* Our target batch size - flush approximately at this point. */ -#define BATCH_SZ (64 * 1024) +#define BATCH_SZ (64 * 1024 - BATCH_RESERVED) enum iris_batch_name { IRIS_BATCH_RENDER, |