summaryrefslogtreecommitdiffstats
path: root/src/gallium/winsys/sw/kms-dri
diff options
context:
space:
mode:
authorTomasz Figa <[email protected]>2016-08-02 19:46:25 +0900
committerEmil Velikov <[email protected]>2016-08-24 14:39:22 +0100
commit0aa6a818ef60e01f304987fe07ac1370d68d38b1 (patch)
tree5c3fd1e2e26418790c83a678539d04c0208c968d /src/gallium/winsys/sw/kms-dri
parentb4959e17f18aff68465f4b3445b6a53ee0227b16 (diff)
gallium/winsys/kms: Fix double refcount when importing from prime FD (v2)
Currently the code creates a display target struct with refcount field initialized to 1 and then the caller again increments it, leading to a leaked reference. Let's remove the unnecessary increment. v2: Split from one big patch into four fixing one thing at a time. Signed-off-by: Tomasz Figa <[email protected]> CC: <[email protected]> Reviewed-by: Hans de Goede <[email protected]> Reviewed-by: Emil Velikov <[email protected]>
Diffstat (limited to 'src/gallium/winsys/sw/kms-dri')
-rw-r--r--src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c
index 21ac0d7dae8..0585fcce207 100644
--- a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c
+++ b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c
@@ -276,7 +276,6 @@ kms_sw_displaytarget_from_handle(struct sw_winsys *ws,
case DRM_API_HANDLE_TYPE_FD:
kms_sw_dt = kms_sw_displaytarget_add_from_prime(kms_sw, whandle->handle);
if (kms_sw_dt) {
- kms_sw_dt->ref_count++;
kms_sw_dt->width = templ->width0;
kms_sw_dt->height = templ->height0;
kms_sw_dt->stride = whandle->stride;