summaryrefslogtreecommitdiffstats
path: root/src/gallium/winsys/svga
diff options
context:
space:
mode:
authorRoland Scheidegger <[email protected]>2016-01-21 00:04:56 +0100
committerRoland Scheidegger <[email protected]>2016-01-21 00:09:55 +0100
commite925ec881128651b97ba747f644e921597a1c209 (patch)
treeb2d12cf28fac574f4c7d7a26f618436239f66da2 /src/gallium/winsys/svga
parentdc3ac418bf889620c93f50c68ef55b9e9de3afd3 (diff)
llvmpipe,i915: add back NEW_RASTERIZER dependency when computing vertex info
I removed this mistakenly in 2dbc20e45689e09766552517a74e2270e49817b5. I actually thought it should not be necessary and a piglit run didn't show any differences, but this shouldn't have been in there. draw_prepare_shader_outputs() is in fact dependent on NEW_RASTERIZER. The new polygon-mode-facing test indeed shows why this is necessary, there's lots of invalid reads and writes with valgrind (also crashes without valgrind), because the pre-pipeline vertex size doesn't match the post-pipeline vertex size (note this won't help much with stages which don't have the prepare hook which can grow the vertex size, in particular the wide point stage, but this isn't used by llvmpipe). The test still won't pass, of course, but it is only usage of uninitialized values now, which is much less dangerous... (Albeit I'm pretty sure for i915 it really is not needed anymore as it doesn't care about the extra outputs and doesn't call draw_prepare_shader_outputs().) Reviewed-by: Jose Fonseca <[email protected]>
Diffstat (limited to 'src/gallium/winsys/svga')
0 files changed, 0 insertions, 0 deletions