diff options
| author | Christian König <[email protected]> | 2013-09-21 15:24:55 +0200 |
|---|---|---|
| committer | Christian König <[email protected]> | 2013-09-22 10:33:20 +0200 |
| commit | 0653c66ef40ac553f91b29bbda7f59f7ce6948fa (patch) | |
| tree | cd65b7c34f09363d2a58036b57b368ef52a3d9d4 /src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | |
| parent | f7ccb84aa1cd64703308dece03da0d4eb3bf4951 (diff) | |
winsys/radeon: remove cs_queue_empty
Waiting for an empty queue is nonsense and can lead to deadlocks if we have
multiple waiters or another thread that continuously sends down new commands.
Just post the cs to the queue and immediately wait for it to finish.
This is a candidate for the stable branch.
Signed-off-by: Christian König <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
Diffstat (limited to 'src/gallium/winsys/radeon/drm/radeon_drm_winsys.h')
| -rw-r--r-- | src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.h b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.h index 682479ed52c..ed901948634 100644 --- a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.h +++ b/src/gallium/winsys/radeon/drm/radeon_drm_winsys.h @@ -67,11 +67,6 @@ struct radeon_drm_winsys { /* rings submission thread */ pipe_mutex cs_stack_lock; pipe_semaphore cs_queued; - /* we cannot use semaphore for empty queue because maintaining an even - * number of call to semaphore_wait and semaphore_signal is, to say the - * least, tricky - */ - pipe_condvar cs_queue_empty; pipe_thread thread; int kill_thread; int ncs; |