diff options
author | Nicolai Hähnle <[email protected]> | 2017-09-10 19:46:31 +0200 |
---|---|---|
committer | Nicolai Hähnle <[email protected]> | 2017-09-13 18:25:45 +0200 |
commit | e4af4433fc802fafcb6050e290c514ff40c8735d (patch) | |
tree | 8208f4f8058d1aa18048f22fb8decdc326f73415 /src/gallium/tests/graw/fs-fragcoord.c | |
parent | 92c4277990799641d4986ce66a62366228713945 (diff) |
radeonsi: hard-code pixel center for interpolateAtSample without multisample buffers
The GLSL rules for interpolateAtSample are unfortunate:
"Returns the value of the input interpolant variable at
the location of sample number sample. If
multisample buffers are not available, the input
variable will be evaluated at the center of the pixel.
If sample sample does not exist, the position used to
interpolate the input variable is undefined."
This fix will fallback to monolithic shader compilation when
interpolateAtSample is used without multisampling.
One alternative would be to always upload 16 sample positions,
filling the buffer up with repetition when the actual number of
samples is less, and then ANDing the sample ID with 0xf. However,
that punishes all well-behaving users of interpolateAtSample,
when in reality, only conformance tests should be affected by
the issue.
Fixes
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.non_multisample_buffer.*
Reviewed-by: Marek Olšák <[email protected]>
Diffstat (limited to 'src/gallium/tests/graw/fs-fragcoord.c')
0 files changed, 0 insertions, 0 deletions