summaryrefslogtreecommitdiffstats
path: root/src/gallium/drivers
diff options
context:
space:
mode:
authorEric Anholt <[email protected]>2017-11-02 12:19:10 -0700
committerEric Anholt <[email protected]>2017-11-07 09:40:25 -0800
commita266f78741bfdf6802b49df77d4611d6084408e9 (patch)
treec2dacd7f259b047844e25468ad7865b436ce5b91 /src/gallium/drivers
parent73ec70bf13a939e687ddf9c2a7e08962042a09eb (diff)
broadcom/vc5: Fix mipmap filtering enums.
The ordering of the values was even less obvious than I thought, with both the mip filter and the min filter being in different bits depending on whether the mip filter is none. Fixes piglit fs-textureLod-miplevels.shader_test
Diffstat (limited to 'src/gallium/drivers')
-rw-r--r--src/gallium/drivers/vc5/vc5_emit.c14
1 files changed, 8 insertions, 6 deletions
diff --git a/src/gallium/drivers/vc5/vc5_emit.c b/src/gallium/drivers/vc5/vc5_emit.c
index 8a606c4990a..ea646e7d510 100644
--- a/src/gallium/drivers/vc5/vc5_emit.c
+++ b/src/gallium/drivers/vc5/vc5_emit.c
@@ -149,20 +149,22 @@ emit_one_texture(struct vc5_context *vc5, struct vc5_texture_stateobj *stage_tex
mag_img_filter = PIPE_TEX_FILTER_NEAREST;
}
- bool min_nearest = (min_img_filter == PIPE_TEX_FILTER_NEAREST);
+ bool min_nearest = min_img_filter == PIPE_TEX_FILTER_NEAREST;
switch (min_mip_filter) {
case PIPE_TEX_MIPFILTER_NONE:
- unpacked.minification_filter = 0 + min_nearest;
+ unpacked.filter += min_nearest ? 2 : 0;
break;
case PIPE_TEX_MIPFILTER_NEAREST:
- unpacked.minification_filter = 2 + !min_nearest;
+ unpacked.filter += min_nearest ? 4 : 8;
break;
case PIPE_TEX_MIPFILTER_LINEAR:
- unpacked.minification_filter = 4 + !min_nearest;
+ unpacked.filter += min_nearest ? 4 : 8;
+ unpacked.filter += 2;
break;
}
- unpacked.magnification_filter = (mag_img_filter ==
- PIPE_TEX_FILTER_NEAREST);
+
+ if (mag_img_filter == PIPE_TEX_FILTER_NEAREST)
+ unpacked.filter++;
uint8_t packed[cl_packet_length(TEXTURE_SHADER_STATE)];
cl_packet_pack(TEXTURE_SHADER_STATE)(&job->indirect, packed, &unpacked);