diff options
| author | Ernestas Kulik <[email protected]> | 2018-08-30 19:02:47 +0300 |
|---|---|---|
| committer | Eric Anholt <[email protected]> | 2019-01-29 16:14:13 -0800 |
| commit | f6e49d5ad0fde19a074644491475470d684dd721 (patch) | |
| tree | 40634a83df70dd5465311c42c741a33f90c85b44 /src/gallium/drivers/vc4 | |
| parent | 6053c7bb436a4a8cdb63e6015b4b5d87c6723081 (diff) | |
vc4: Fix leak in HW queries error path
Reported by Coverity: in the case where there exist hardware and
non-hardware queries, the code does not jump to err_free_query and leaks
the query.
CID: 1430194
Signed-off-by: Ernestas Kulik <[email protected]>
Fixes: 9ea90ffb98fb ("broadcom/vc4: Add support for HW perfmon")
Diffstat (limited to 'src/gallium/drivers/vc4')
| -rw-r--r-- | src/gallium/drivers/vc4/vc4_query.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/vc4/vc4_query.c b/src/gallium/drivers/vc4/vc4_query.c index 6e4681e93cc..f08785f457f 100644 --- a/src/gallium/drivers/vc4/vc4_query.c +++ b/src/gallium/drivers/vc4/vc4_query.c @@ -132,7 +132,7 @@ vc4_create_batch_query(struct pipe_context *pctx, unsigned num_queries, /* We can't mix HW and non-HW queries. */ if (nhwqueries && nhwqueries != num_queries) - return NULL; + goto err_free_query; if (!nhwqueries) return (struct pipe_query *)query; |