diff options
author | Eric Anholt <[email protected]> | 2014-10-06 15:47:38 -0700 |
---|---|---|
committer | Eric Anholt <[email protected]> | 2014-10-09 11:01:09 +0200 |
commit | 67aea92964ed06f10097271822f4a16378138be5 (patch) | |
tree | 41883924b38cfa21513fae0a1e00678d14fc4dda /src/gallium/drivers/vc4/vc4_resource.c | |
parent | 0b96a086cbb4bcf0a5aab1fee6d77c1e40295297 (diff) |
vc4: Mostly fix offset calculation for NPOT mipmap levels.
The non-base NPOT levels are stored as POT-aligned images. We get that
POT alignment by minifying the POT-aligned base level.
This means that level strides are also POT aligned, so we have to tell the
rendering mode config that our resource is larger than the actual
requested area.
Fixes the fbo-generatemipmap-formats NPOT cases. Regresses
depthstencil-render-miplevels 273 * -- the texture presentation now works
(where it was completely broken before), it looks like there's some
overflow of image bounds happening at the lower miplevels.
Diffstat (limited to 'src/gallium/drivers/vc4/vc4_resource.c')
-rw-r--r-- | src/gallium/drivers/vc4/vc4_resource.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c index 239443e7a7d..7006af3d8ff 100644 --- a/src/gallium/drivers/vc4/vc4_resource.c +++ b/src/gallium/drivers/vc4/vc4_resource.c @@ -198,14 +198,23 @@ vc4_setup_slices(struct vc4_resource *rsc) struct pipe_resource *prsc = &rsc->base.b; uint32_t width = prsc->width0; uint32_t height = prsc->height0; + uint32_t pot_width = util_next_power_of_two(width); + uint32_t pot_height = util_next_power_of_two(height); uint32_t offset = 0; uint32_t utile_w = vc4_utile_width(rsc->cpp); uint32_t utile_h = vc4_utile_height(rsc->cpp); for (int i = prsc->last_level; i >= 0; i--) { struct vc4_resource_slice *slice = &rsc->slices[i]; - uint32_t level_width = u_minify(width, i); - uint32_t level_height = u_minify(height, i); + + uint32_t level_width, level_height; + if (i == 0) { + level_width = width; + level_height = height; + } else { + level_width = u_minify(pot_width, i); + level_height = u_minify(pot_height, i); + } if (rsc->tiled == VC4_TILING_FORMAT_LINEAR) { slice->tiling = VC4_TILING_FORMAT_LINEAR; |