diff options
| author | Eric Anholt <[email protected]> | 2018-02-20 16:05:29 +0000 |
|---|---|---|
| committer | Eric Anholt <[email protected]> | 2018-02-23 08:42:13 -0800 |
| commit | 6deb158ec1e03027d855df6a2513c8595ed95924 (patch) | |
| tree | f9138377134e2fa4699d1b7a00ded7b6b44b23aa /src/gallium/drivers/vc4/vc4_bufmgr.h | |
| parent | 34ea1aca92ce20a95e4f5d41325fb965a2b96986 (diff) | |
broadcom/vc4: Add pipe_reference debugging for vc4_bos.
Trying to track down the YUV EGLImage use-after-free, it helps to see what
the mystery objects are that are being refcounted.
Diffstat (limited to 'src/gallium/drivers/vc4/vc4_bufmgr.h')
| -rw-r--r-- | src/gallium/drivers/vc4/vc4_bufmgr.h | 19 |
1 files changed, 15 insertions, 4 deletions
diff --git a/src/gallium/drivers/vc4/vc4_bufmgr.h b/src/gallium/drivers/vc4/vc4_bufmgr.h index ecd0daa7c70..9fa4774427e 100644 --- a/src/gallium/drivers/vc4/vc4_bufmgr.h +++ b/src/gallium/drivers/vc4/vc4_bufmgr.h @@ -73,10 +73,13 @@ struct vc4_bo *vc4_bo_open_dmabuf(struct vc4_screen *screen, int fd, bool vc4_bo_flink(struct vc4_bo *bo, uint32_t *name); int vc4_bo_get_dmabuf(struct vc4_bo *bo); +void vc4_bo_debug_describe(char* buf, const struct vc4_bo *ptr); static inline struct vc4_bo * vc4_bo_reference(struct vc4_bo *bo) { - pipe_reference(NULL, &bo->reference); + pipe_reference_described(NULL, &bo->reference, + (debug_reference_descriptor) + vc4_bo_debug_describe); return bo; } @@ -89,13 +92,18 @@ vc4_bo_unreference(struct vc4_bo **bo) if ((*bo)->private) { /* Avoid the mutex for private BOs */ - if (pipe_reference(&(*bo)->reference, NULL)) + if (pipe_reference_described(&(*bo)->reference, NULL, + (debug_reference_descriptor) + vc4_bo_debug_describe)) { vc4_bo_last_unreference(*bo); + } } else { screen = (*bo)->screen; mtx_lock(&screen->bo_handles_mutex); - if (pipe_reference(&(*bo)->reference, NULL)) { + if (pipe_reference_described(&(*bo)->reference, NULL, + (debug_reference_descriptor) + vc4_bo_debug_describe)) { util_hash_table_remove(screen->bo_handles, (void *)(uintptr_t)(*bo)->handle); vc4_bo_last_unreference(*bo); @@ -113,8 +121,11 @@ vc4_bo_unreference_locked_timed(struct vc4_bo **bo, time_t time) if (!*bo) return; - if (pipe_reference(&(*bo)->reference, NULL)) + if (pipe_reference_described(&(*bo)->reference, NULL, + (debug_reference_descriptor) + vc4_bo_debug_describe)) { vc4_bo_last_unreference_locked_timed(*bo, time); + } *bo = NULL; } |