diff options
| author | Roland Scheidegger <[email protected]> | 2018-03-02 03:00:41 +0100 |
|---|---|---|
| committer | Roland Scheidegger <[email protected]> | 2018-03-06 05:18:17 +0100 |
| commit | 06e724c7b4ade29868531edb20900859f566a077 (patch) | |
| tree | 3bc0c19b2094ba6e035a0ce85dc2c35cecc59de0 /src/gallium/drivers/swr/swr_shader.cpp | |
| parent | 95ae6c0355379127706e516d177f7f6ee8296d48 (diff) | |
tgsi/scan: use wrap-around shift behavior explicitly for file_mask
The comment said it will only represent the lowest 32 regs. This was
not entirely true in practice, since at least on x86 you'll get
masked shifts (unless the compiler could recognize it already and toss
it out). It turns out this actually works out alright (presumably
noone uses it for temp regs) when increasing max sampler views, so
make that behavior explicit.
Albeit it feels a bit hacky (but in any case, explicit behavior there
is better than undefined behavior).
Reviewed-by: Jose Fonseca <[email protected]>
Reviewed-by: Brian Paul <[email protected]>
Diffstat (limited to 'src/gallium/drivers/swr/swr_shader.cpp')
| -rw-r--r-- | src/gallium/drivers/swr/swr_shader.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/swr/swr_shader.cpp b/src/gallium/drivers/swr/swr_shader.cpp index e5fb679f8b3..477fa7f2db4 100644 --- a/src/gallium/drivers/swr/swr_shader.cpp +++ b/src/gallium/drivers/swr/swr_shader.cpp @@ -98,7 +98,7 @@ swr_generate_sampler_key(const struct lp_tgsi_info &info, key.nr_sampler_views = info.base.file_max[TGSI_FILE_SAMPLER_VIEW] + 1; for (unsigned i = 0; i < key.nr_sampler_views; i++) { - if (info.base.file_mask[TGSI_FILE_SAMPLER_VIEW] & (1 << i)) { + if (info.base.file_mask[TGSI_FILE_SAMPLER_VIEW] & (1u << (i & 31))) { const struct pipe_sampler_view *view = ctx->sampler_views[shader_type][i]; lp_sampler_static_texture_state( |