diff options
| author | Brian Paul <[email protected]> | 2018-10-09 08:55:46 -0600 |
|---|---|---|
| committer | Brian Paul <[email protected]> | 2018-10-09 11:17:14 -0600 |
| commit | 797e34f65879039aecc0a677c44af0a1185edfd7 (patch) | |
| tree | ab83b7f7559a43e7adb04cfa9ddccbaaec5a8f80 /src/gallium/drivers/svga/svga_shader.h | |
| parent | b781688636a42be2120047b868abc9bab823acbf (diff) | |
svga: change svga_destroy_shader_variant() to return void
svga_destroy_shader_variant() itself flushes and retries the command
if there's a failure. So no need for the callers to do it. Other
callers of the function were already ignoring the return value.
This also fixes a corner-case double-free reported by Coverity
(and reported by Dave Airlie).
Tested with various OpenGL apps.
Reviewed-by: Charmaine Lee <[email protected]>
Diffstat (limited to 'src/gallium/drivers/svga/svga_shader.h')
| -rw-r--r-- | src/gallium/drivers/svga/svga_shader.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/svga/svga_shader.h b/src/gallium/drivers/svga/svga_shader.h index b80cf181441..68991e72641 100644 --- a/src/gallium/drivers/svga/svga_shader.h +++ b/src/gallium/drivers/svga/svga_shader.h @@ -285,7 +285,7 @@ svga_set_shader(struct svga_context *svga, struct svga_shader_variant * svga_new_shader_variant(struct svga_context *svga); -enum pipe_error +void svga_destroy_shader_variant(struct svga_context *svga, SVGA3dShaderType type, struct svga_shader_variant *variant); |