diff options
author | Ilia Mirkin <[email protected]> | 2015-09-25 16:34:07 -0400 |
---|---|---|
committer | Ilia Mirkin <[email protected]> | 2015-09-28 17:28:54 -0400 |
commit | d4e650b07bc80075f0d088e7d85df9efa45e11bd (patch) | |
tree | 6b0d171131dfca4ea705397f66256e1069c1be49 /src/gallium/drivers/nouveau/nv30 | |
parent | 4c5308bbf4fa5c6ac274f6e1ab7c8846a2866976 (diff) |
nouveau: be more careful about freeing temporary transfer buffers
Deleting a buffer does not flush the command stream. Make sure that we
wait for the copies to finish before deleting the temporary bo.
Signed-off-by: Ilia Mirkin <[email protected]>
Cc: [email protected]
Tested-by: Marcin Ĺšlusarz <[email protected]>
Diffstat (limited to 'src/gallium/drivers/nouveau/nv30')
-rw-r--r-- | src/gallium/drivers/nouveau/nv30/nv30_miptree.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/gallium/drivers/nouveau/nv30/nv30_miptree.c b/src/gallium/drivers/nouveau/nv30/nv30_miptree.c index 735c718c4b3..c6f69650068 100644 --- a/src/gallium/drivers/nouveau/nv30/nv30_miptree.c +++ b/src/gallium/drivers/nouveau/nv30/nv30_miptree.c @@ -339,10 +339,15 @@ nv30_miptree_transfer_unmap(struct pipe_context *pipe, struct nv30_context *nv30 = nv30_context(pipe); struct nv30_transfer *tx = nv30_transfer(ptx); - if (ptx->usage & PIPE_TRANSFER_WRITE) + if (ptx->usage & PIPE_TRANSFER_WRITE) { nv30_transfer_rect(nv30, NEAREST, &tx->tmp, &tx->img); - nouveau_bo_ref(NULL, &tx->tmp.bo); + /* Allow the copies above to finish executing before freeing the source */ + nouveau_fence_work(nv30->screen->base.fence.current, + nouveau_fence_unref_bo, tx->tmp.bo); + } else { + nouveau_bo_ref(NULL, &tx->tmp.bo); + } pipe_resource_reference(&ptx->resource, NULL); FREE(tx); } |