diff options
| author | José Fonseca <[email protected]> | 2012-12-09 10:15:19 +0000 |
|---|---|---|
| committer | José Fonseca <[email protected]> | 2012-12-20 16:33:49 +0000 |
| commit | ab2f573634d21cf5d2c0843960b98e890d495793 (patch) | |
| tree | 03ebcde34434e1d1d3e7b5233d29856952d4f149 /src/gallium/drivers/llvmpipe/lp_query.c | |
| parent | 3160b0b9fc2b49b0e9fe684b955eebf3691024ff (diff) | |
llvmpipe: Drop PIPE_QUERY_TIME_ELAPSED support.
It was slightly wrong: we were computing the longest duration of
the query among all the rasterizer tasks.
Regardless, for tile-based implementations such as llvmpipe, time differences
will never be very useful, because rendering before/during/after the query
is all interleaved. And this is expected, see ARB_timer_query spec, issue 10.
In particular, piglit ext_timer_query-time-elapsed still fails, because
it makes assumptions that don't hold true in in tiled architectures. Not
sure how to fix that though.
Reviewed-by: Dave Airlie <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
Reviewed-by: Brian Paul <[email protected]>
Diffstat (limited to 'src/gallium/drivers/llvmpipe/lp_query.c')
| -rw-r--r-- | src/gallium/drivers/llvmpipe/lp_query.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/gallium/drivers/llvmpipe/lp_query.c b/src/gallium/drivers/llvmpipe/lp_query.c index 7a62a809d58..01d5201a100 100644 --- a/src/gallium/drivers/llvmpipe/lp_query.c +++ b/src/gallium/drivers/llvmpipe/lp_query.c @@ -122,13 +122,6 @@ llvmpipe_get_query_result(struct pipe_context *pipe, *result += pq->count[i]; } break; - case PIPE_QUERY_TIME_ELAPSED: - for (i = 0; i < LP_MAX_THREADS; i++) { - if (pq->count[i] > *result) { - *result = pq->count[i]; - } - } - break; case PIPE_QUERY_TIMESTAMP: for (i = 0; i < LP_MAX_THREADS; i++) { if (pq->count[i] > *result) { |