diff options
| author | Jason Ekstrand <[email protected]> | 2019-05-06 11:45:46 -0500 |
|---|---|---|
| committer | Jason Ekstrand <[email protected]> | 2019-05-24 08:38:11 -0500 |
| commit | f2dc0f28728af63e1a79756dab06a7035fecb590 (patch) | |
| tree | 567ce89be4af1fc48d287415ab051929f0e1466e /src/gallium/drivers/lima | |
| parent | 22421ca7be608f38ce701a43e3f6b7f3132b7aab (diff) | |
nir: Drop imov/fmov in favor of one mov instruction
The difference between imov and fmov has been a constant source of
confusion in NIR for years. No one really knows why we have two or when
to use one vs. the other. The real reason is that they do different
things in the presence of source and destination modifiers. However,
without modifiers (which many back-ends don't have), they are identical.
Now that we've reworked nir_lower_to_source_mods to leave one abs/neg
instruction in place rather than replacing them with imov or fmov
instructions, we don't need two different instructions at all anymore.
Reviewed-by: Kristian H. Kristensen <[email protected]>
Reviewed-by: Alyssa Rosenzweig <[email protected]>
Reviewed-by: Vasily Khoruzhick <[email protected]>
Acked-by: Rob Clark <[email protected]>
Diffstat (limited to 'src/gallium/drivers/lima')
| -rw-r--r-- | src/gallium/drivers/lima/ir/gp/nir.c | 2 | ||||
| -rw-r--r-- | src/gallium/drivers/lima/ir/pp/nir.c | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/src/gallium/drivers/lima/ir/gp/nir.c b/src/gallium/drivers/lima/ir/gp/nir.c index dcfbc450091..49010d3c255 100644 --- a/src/gallium/drivers/lima/ir/gp/nir.c +++ b/src/gallium/drivers/lima/ir/gp/nir.c @@ -129,7 +129,7 @@ static int nir_to_gpir_opcodes[nir_num_opcodes] = { [nir_op_fand] = gpir_op_min, [nir_op_for] = gpir_op_max, [nir_op_fabs] = gpir_op_abs, - [nir_op_fmov] = gpir_op_mov, + [nir_op_mov] = gpir_op_mov, }; static bool gpir_emit_alu(gpir_block *block, nir_instr *ni) diff --git a/src/gallium/drivers/lima/ir/pp/nir.c b/src/gallium/drivers/lima/ir/pp/nir.c index bb5038541ea..1d390827b07 100644 --- a/src/gallium/drivers/lima/ir/pp/nir.c +++ b/src/gallium/drivers/lima/ir/pp/nir.c @@ -117,8 +117,7 @@ static int nir_to_ppir_opcodes[nir_num_opcodes] = { /* not supported */ [0 ... nir_last_opcode] = -1, - [nir_op_fmov] = ppir_op_mov, - [nir_op_imov] = ppir_op_mov, + [nir_op_mov] = ppir_op_mov, [nir_op_fmul] = ppir_op_mul, [nir_op_fadd] = ppir_op_add, [nir_op_fdot2] = ppir_op_dot2, |